Skip to content

Update multiselect.js #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2019
Merged

Update multiselect.js #1025

merged 1 commit into from
Aug 3, 2019

Conversation

@webskin
Copy link
Contributor

@webskin webskin commented Jul 24, 2019 •
edited
Loading

Hello,
applyFilter should take the entire selection and not just the first element of the sélection

@webskin
Update multiselect.js
33df211 
applyFilter should take the entire selection and not just the first element of the sélection
@AllenFang
Copy link
Member

AllenFang commented Jul 27, 2019

hello @webskin, would you please give me an explain about what issue or bug you found? thanks. I think theres gonna be a reason about this PR

@webskin
Copy link
Contributor Author

webskin commented Jul 29, 2019 •
edited
Loading

Hello @AllenFang , sometimes when playing with defaultValue for multiselect filter, componentDidMount is executed and then the multiselection (onTableChange) is changed in a simple selection. Exemple :

multiSelectFilter.filterVal == ['foo', 'bar'] 
// changes in
multiSelectFilter.filterVal == 'foo'

@AllenFang AllenFang changed the base branch from master to develop August 3, 2019 07:46
@AllenFang AllenFang merged commit 0c2863d into react-bootstrap-table:develop Aug 3, 2019
@AllenFang
Copy link
Member

AllenFang commented Aug 3, 2019

@webskin thanks, I will release in next verison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@webskin @AllenFang